Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug modes #609

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Fix debug modes #609

merged 1 commit into from
Nov 23, 2022

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis force-pushed the fix-debug-mode branch 6 times, most recently from 57045a2 to 5ae404f Compare November 23, 2022 18:23
@blckmn
Copy link
Member

blckmn commented Nov 23, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
42.4% 42.4% Duplication

ctzsnooze
ctzsnooze approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@ctzsnooze ctzsnooze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested!
APPROVED

js/flightlog_fielddefs.js Show resolved Hide resolved
@ctzsnooze ctzsnooze mentioned this pull request Nov 23, 2022
Closed
@haslinghuis haslinghuis added this to the 3.7.0 milestone Nov 23, 2022
@haslinghuis haslinghuis merged commit b5657e4 into betaflight:master Nov 23, 2022
@haslinghuis haslinghuis deleted the fix-debug-mode branch November 23, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX Tested
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @blckmn @ctzsnooze