Met à jour la var d'env pour le tracer openfisca #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillett
reviewed
Mar 7, 2024
| {% else %} | ||
| MES_AIDES_ROOT_URL: http://{{ item.domain }} | ||
| OPENFISCA_PUBLIC_ROOT_URL: http://openfisca.{{ item.domain }} | ||
| OPENFISCA_TRACER_URL: http://127.0.0.1:3000 |
There was a problem hiding this comment.
Ah intéressant, je n'avais pas pensé à ça. 🤔 est ce qu'on met ça là où bien dans tous les cas en déploiement c'est https://openfisca.github.io/tracer et donc on le sort du bloc conditionnel ?
There was a problem hiding this comment.
J'ai fait cela un peu par défaut mais cela m'a l'air plus cohérent de faire ta suggestion de le sortir du bloc
Sort la var d'env du bloc: elle est utilisée dans tous les cas
guillett
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion en lien avec betagouv/aides-jeunes#4229