-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support .NET Standard 2.0 #84
Conversation
* Add Extension for Interfaces * Update HttpClientExtension * Create Simple Test Project
thanks for the contribution, but it is quite a big one. Next time if you can create with small changes it would be easier to review. The first thing I have noticed with these changes we lose the async stream ability. The method waits until the whole response is completed. Please compare in the playground before your changes and after. |
I found a little odd that the method PostAsStreamAsync was not async, but the name of the method is so I changed. And the netstandard does not have Send method in the client that's the reason I changed, are you sure the method was working async, I try to create a test for test that but I'm not sure if is working like before. I only changed that was necessary to make work with netstandard, add the Test just to make sure does not break anything. |
Please check this comment (#73 (comment)). We struggled a bit to make this method work. I will check it to see if it fits with the suggested implementation whenever I have time. currently, in the master branch, it works. |
with .netstandart2 support, we may need to consider creating a new project in the solution. I just created a discussion about this #86. It would be nice to see your thoughts there |
I gonna create a new branch and create a unit test project to see how the |
I didn't find any difference between the |
I will prepare a video to show the difference as soon as I find some time. |
https://youtu.be/rGc1X2aD2ms |
https://github.com/betalgo/openai/tree/feature/DotNetStandardSupport |
Completed in a different branch and released as part of v6.8.0 |
Things that were added/changed.
PostAsStreamAsync
to async