fix: improve time compare range error (apache#11252)

betodealmeida · Oct 13, 2020 · 16f7b2b · 16f7b2b
1 parent 8676c3e
commit 16f7b2b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/superset/viz.py b/superset/viz.py
@@ -1405,8 +1405,8 @@ def run_extra_queries(self) -> None:
             if not query_object["from_dttm"] or not query_object["to_dttm"]:
                 raise QueryObjectValidationError(
                     _(
-                        "`Since` and `Until` time bounds should be specified "
-                        "when using the `Time Shift` feature."
+                        "An enclosed time range (both start and end) must be specified "
+                        "when using a Time Comparison."
                     )
                 )
             query_object["from_dttm"] -= delta

diff --git a/superset/viz_sip38.py b/superset/viz_sip38.py
@@ -1275,8 +1275,8 @@ def run_extra_queries(self):
             if not query_object["from_dttm"] or not query_object["to_dttm"]:
                 raise QueryObjectValidationError(
                     _(
-                        "`Since` and `Until` time bounds should be specified "
-                        "when using the `Time Shift` feature."
+                        "An enclosed time range (both start and end) must be specified "
+                        "when using a Time Comparison."
                     )
                 )
             query_object["from_dttm"] -= delta