Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js v16 support AKA broadened ranges fix #235

Closed
balupton opened this issue Jul 28, 2021 · 2 comments
Closed

Node.js v16 support AKA broadened ranges fix #235

balupton opened this issue Jul 28, 2021 · 2 comments

Comments

@balupton
Copy link
Member

balupton commented Jul 28, 2021

Broadened ranges are not working correctly, and as such, this is causing packages with edition definitions that only support up to Node.js v14 to fail on Node.js v16.

Prior the recent changes of today, this was not being reported correctly, and the logging was too complicated to understand. The recent changes now report it correctly, and will help me identify why the broadened range code is done in such a silly way, so that I can try and understand what is the correct path forward.

Will update this as I go.

❤️ Please consider funding my work so things like this never happen in the first place, or when they do happen, I can afford the time to fix them speedily.

@balupton balupton changed the title Node.js v16 support/fix AKA broadened ranges fix Node.js v16 support AKA broadened ranges fix Jul 28, 2021
@balupton
Copy link
Member Author

This has been resolved in Editions v6.5.0 and is being pushed out now to all the Bevry packages.

https://github.com/bevry/editions/releases/tag/v6.5.0

Better tests, documentation, and reporting have all been added so that this cannot happen again.

❤️ Please consider funding my work so things like this never happen in the first place, or when they do happen, I can afford the time to fix them speedily.

@balupton
Copy link
Member Author

Seems it is stuck in GitHub Actions limbo:

https://github.com/bevry/editions/actions/runs/1075641317

Not sure how long it will take to get actually get published...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant