fix: Support Node 16 via editions #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of Node 16, the `editions` configuration in package.json needs to be updated to support this version.
This was referenced Apr 30, 2021
Closed
cbush
added a commit
to cbush/Bluehawk
that referenced
this pull request
May 12, 2021
- Waiting for bevry/istextorbinary#201 - Meanwhile, replace with a different library to do the same thing
cbush
added a commit
to mongodb-university/Bluehawk
that referenced
this pull request
May 12, 2021
* Node 16 support: replace isbinaryortext with isbinaryfile - Waiting for bevry/istextorbinary#201 - Meanwhile, replace with a different library to do the same thing * Add binary test
|
Thank you for providing this in-between workaround that people could directly use in the meantime. The root cause has now been fixed and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Node 16, the
editionsconfiguration in package.json needs to be updated to support this version.