Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic linking instructions broken for Windows #131

Closed
Alainx277 opened this issue Apr 13, 2021 · 2 comments
Closed

Dynamic linking instructions broken for Windows #131

Alainx277 opened this issue Apr 13, 2021 · 2 comments
Labels
A-Book C-Bug A problem with the code that runs the site

Comments

@Alainx277
Copy link

Following the setup guide for fast builds on windows leads to errors when using dynamic linking. There seem to be two issues, which both have the solution of turning off "share-generics" for windows builds (bevyengine/bevy#1126, bevyengine/bevy#1110).

Maybe it would be good to offer a solution in the setup guide, or perhaps even temporarily turn off shared generics in the cargo config template.

bors bot pushed a commit to bevyengine/bevy that referenced this issue Aug 30, 2021
It seems like this option needs to be off on Windows: bevyengine/bevy-website#131

This change also simplifies the instructions required for the Fast Compiles section of the book: bevyengine/bevy-website#137
bilsen pushed a commit to bilsen/bevy that referenced this issue Sep 2, 2021
It seems like this option needs to be off on Windows: bevyengine/bevy-website#131

This change also simplifies the instructions required for the Fast Compiles section of the book: bevyengine/bevy-website#137
@alice-i-cecile alice-i-cecile added C-Bug A problem with the code that runs the site C-Docs A-Book labels Mar 30, 2022
@cart cart removed the C-Docs label Mar 30, 2022
@paul-hansen
Copy link
Contributor

This should be working on Windows now afaik. I've been using it on Windows for awhile now.

The trick is that you need these lines on Windows or it doesn't work:

# Enable a small amount of optimization in debug mode
[profile.dev]
opt-level = 1

# Enable high optimizations for dependencies (incl. Bevy), but not for our code:
[profile.dev.package."*"]
opt-level = 3

We should probably remove Note that right now, this doesn't work on Windows from the setup instructions from the book, and emphasize that the opt-level lines are needed for Windows.

See for more info see comments: bevyengine/bevy#1110 (comment) and bevyengine/bevy#2921 (comment)

@mnmaita
Copy link
Member

mnmaita commented May 12, 2023

Closing as per #628! Please re-open if you find the issue persists.

@mnmaita mnmaita closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Book C-Bug A problem with the code that runs the site
Projects
None yet
Development

No branches or pull requests

5 participants