Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write in a alternative logo-title if name is not given #1644

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

MyZeD
Copy link
Contributor

@MyZeD MyZeD commented Oct 8, 2024

The change ensures that if a donor's name is not provided, the alt attribute for the donor's logo will use the filename (without the extension) as the alternative text.

  • templates/sponsors.html: Added a fallback for the alt attribute to use the donor's logo filename if the donor's name is not available.

@alice-i-cecile alice-i-cecile added C-Webdev A-Foundation Donations, minutes and other bureaucracy S-Needs-Review labels Oct 11, 2024
@TrialDragon TrialDragon added S-Ready-For-Final-Review Ready for a maintainer to consider for merging D-Trivial and removed S-Needs-Review labels Oct 19, 2024
@BD103
Copy link
Member

BD103 commented Oct 20, 2024

@MyZeD could you update your branch to have the latest changes in main? There should be a nice button on this page that does it for you :)

The CI error was unrelated to your changes, so if you update we can then merge this!

@alice-i-cecile
Copy link
Member

I can press that button too :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 20, 2024
Merged via the queue into bevyengine:main with commit 68a2af5 Oct 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Foundation Donations, minutes and other bureaucracy C-Webdev D-Trivial S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants