Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code highlighting after zola 0.14 #191

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix code highlighting after zola 0.14 #191

merged 1 commit into from
Jul 21, 2021

Conversation

mockersf
Copy link
Member

  • move the config option to the correct section
  • fix the background color

@cart
Copy link
Member

cart commented Jul 21, 2021

Merged asap because some highlighting is better than no highlighting. Just got my local zola updated. And now I want to tweak this a bit 😄

Heres a quick / rough comparison:

image

  1. right: old
  2. top left: new (with new css tweaks to revert the background to the old color)
  3. bottom left: current main with new background color

My preference is (1), (2), (3). I think (3)'s background sticks out too much. (2) has regrettably lost a lot of contrast compared to (1). I'd like the colors to pop more if possible (like the do in (1)).

I suspect i'll be messing around with this for awhile :)

@cart
Copy link
Member

cart commented Jul 21, 2021

Here is (2) again with the background colors properly synced up:
image

@cart
Copy link
Member

cart commented Jul 21, 2021

Note how bland it looks now 😭

@cart
Copy link
Member

cart commented Jul 22, 2021

Good news! The new release has lots of configuration options. We can now build fully custom css themes: https://www.getzola.org/documentation/content/syntax-highlighting/

@cart
Copy link
Member

cart commented Jul 22, 2021

(which i will absolutely do)

@mockersf
Copy link
Member Author

(which i will absolutely do)

That... doesn't surprise me at all from you 👍

alice-i-cecile pushed a commit to alice-i-cecile/bevy-website that referenced this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants