-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Introduction for ECS chapter #290
[Merged by Bors] - Introduction for ECS chapter #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change to cut back on the code, I think it makes things more conceptual and less Rust/Bevy-specific.
Are you planning on adding images as well?
After reading the intro I've sketched this chart (ignore spacing/style; its not meant to be pretty), I suppose it's not accurate as it misses stages and probably other stuff I don't even know about… buuuut, could be useful as an entry level birds-eye representation: Somewhat related, this raises the question on how to create charts that are maintainable, consistent and pretty. Maybe using something like Figma is a good option here (as it allows to create components, has layout features [e.g. autolayout]…). Has anyone thought about this? |
I actually really like the colors and design— it's simple and effective! If we decide to include an image, I think something like this would be great! It's also nice that it emphasizes the fact that entities are just "numbers" (i.e. Entity 1 is conceptually a paddle). Some small notes:
|
@doup that's great! What's the best way to share and document a Figma file like that? I definitely want an image, and I'm quite happy with what you've come up with. |
Definitely agree with this: the function signatures of systems are always super informative. |
Haha! I just noticed I forgot to change |
Two nits with the graphic:
|
I think that's a good choice. I’d even remove mention of |
Thanks for the suggestions! I've reduced the white-space so now it's more compact, fixed the Downloadable SVG: Dark-mode PNG ( |
I'm currently working on refactoring the Breakout example over on the main repo. Once that's done, I'll revise this text to match. |
I've updated the chart following the changes in: bevyengine/bevy#4261 Downloadable SVG Dark-mode PNG ( |
Wow, I really love the use of color-coding for resource vs component, and the way it makes it clear what the systems are using. I'm really keen to include this, and now I also want an automated tool to make these diagrams 😂 |
Credit to @MrGVSV for the feedback :)
6b3707c
to
a595648
Compare
bors r+ |
Extracted from #182. # Status - [x] Simplify example - [x] Avoid database analogy - [x] Edit and revise for clarity and quality - [x] Fix dead links - [x] Refactor Breakout example on Bevy repo - [x] Update text to sync closely with Breakout example
Pull request successfully merged into new-book. Build succeeded: |
Extracted from #182.
Status