Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Entities and components section for ECS chapter #294

Conversation

alice-i-cecile
Copy link
Member

@alice-i-cecile alice-i-cecile commented Mar 14, 2022

Ported from #182.

Status

  • revisit and revise
  • remove all use of direct world APIs
  • distinguish between Entity type and entity concept

@alice-i-cecile alice-i-cecile force-pushed the ecs-entities-components branch from cef2b78 to b88ee0d Compare May 10, 2022 17:10
@alice-i-cecile alice-i-cecile force-pushed the ecs-entities-components branch from b88ee0d to f0e85e6 Compare May 10, 2022 17:12
@alice-i-cecile alice-i-cecile marked this pull request as ready for review May 10, 2022 17:54
Copy link
Contributor

@doup doup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, I saw a couple of typos on the example queries.

content/learn/book/ecs/entities-components/_index.md Outdated Show resolved Hide resolved
content/learn/book/ecs/entities-components/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Asier Illarramendi <asier@illarra.com>
Copy link
Contributor

@Nilirad Nilirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is quite solid. I have a couple of perplexities about the terminology around entities but those are just personal ones.


## Working with components

Entities are entirely bare when they're spawned: they contain no data other than their unique [`Entity`] identifier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish that Entity was actually called EntityId, so we don't have to always refer to it as “Entity identifier”.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but not something I can do here.

content/learn/book/ecs/entities-components/_index.md Outdated Show resolved Hide resolved
content/learn/book/ecs/entities-components/_index.md Outdated Show resolved Hide resolved
@alice-i-cecile
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request May 14, 2022
Ported from #182.

# Status

- [x] revisit and revise
- [x] remove all use of direct world APIs
- [x] distinguish between `Entity` type and entity concept
@bors
Copy link

bors bot commented May 14, 2022

Build failed:

@alice-i-cecile alice-i-cecile force-pushed the ecs-entities-components branch from e89218a to 6b91ede Compare May 14, 2022 15:46
@alice-i-cecile
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request May 14, 2022
Ported from #182.

# Status

- [x] revisit and revise
- [x] remove all use of direct world APIs
- [x] distinguish between `Entity` type and entity concept
@bors
Copy link

bors bot commented May 14, 2022

Pull request successfully merged into new-book.

Build succeeded:

@bors bors bot changed the title Entities and components section for ECS chapter [Merged by Bors] - Entities and components section for ECS chapter May 14, 2022
@bors bors bot closed this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants