-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - News: Release 0.9.0 #478
Conversation
@MrGVSV May I ask credits in addition to yourself on the implementation of reflection for enums? Note that compared to the whole PR, the correction I provided is not very large, so it's perfectly fine if you refuse. |
Yeah I'm a big believer in giving credit where credit is due. I'd say that since your contributions amounted to more than just a few lines of code, you definitely deserve some amount of credit. And we should also give credit to @Davier for their original PR, which mine was based on. |
} | ||
``` | ||
|
||
No more magic incantations! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you want to include this or not, but it could be worth noting that enums do require that all fields implement FromReflect
.
This is because, we need to be able to clone data out of a &dyn Reflect
and downcast it to the field's type during Reflect::apply
. It's not possible to do that without FromReflect
1 as Reflect::clone_value
may return a Dynamic type for all non-value types (e.g. Struct
, TupleStruct
, etc.).
Footnotes
-
Well, it is possible without
FromReflect
, but all other options were slightly more restrictive imo and could potentially affect the user's desired public API. This included requiring eitherDefault
orClone
. ↩
I suggest to include in the release, that stageless is not part of this release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also get a top level call to action for subject matter experts for animation and audio? We're shorthanded there.
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com> Co-authored-by: Mike <mike.hsu@gmail.com>
Co-authored-by: Mike <mike.hsu@gmail.com>
Co-authored-by: jobstijl <job@jobstijl.nl>
Done! |
|
||
## Derive Resource | ||
|
||
<div class="release-feature-authors">authors: @devil-ira</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A large portion of the work was done by Alice. She definitely deserves credit :)
|
||
<div class="release-feature-authors">authors: @IceSentry</div> | ||
|
||
Some scenarios, [such as shaders](/news/bevy-0-9/#time-shader-globals), need to represent elapsed time values as `f32`, which will suffer from precision issues pretty quickly. To resolve this, [`Time`] has been extended to support "time wrapping": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be interesting to link to The Witness use case as a motivation and best practices.
Looks like you created an extra |
Co-authored-by: ira <JustTheCoolDude@gmail.com>
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
Fixes breaking changes for 0.9. Should be merged at the same time as #478.
bors r+ |
This is an incomplete draft of the 0.9.0 release blog post. Feel free to leave comments / suggest changes / help me fill in gaps I missed! NOTE: This is an _early_ draft and there are still a lot of missing pieces / placeholders. Please only review content that exists and point out missing pieces that don't already have placeholders. Anything with a `[4724]`-style markdown link is a placeholder for content that _might_ need to be included (but also might not be ... these placeholders still need some curation).
Pull request successfully merged into master. Build succeeded: |
This is an incomplete draft of the 0.9.0 release blog post. Feel free to leave comments / suggest changes / help me fill in gaps I missed!
NOTE: This is an early draft and there are still a lot of missing pieces / placeholders. Please only review content that exists and point out missing pieces that don't already have placeholders. Anything with a
[4724]
-style markdown link is a placeholder for content that might need to be included (but also might not be ... these placeholders still need some curation).