Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - News: Release 0.9.0 #478

Closed
wants to merge 27 commits into from

Conversation

cart
Copy link
Member

@cart cart commented Nov 10, 2022

This is an incomplete draft of the 0.9.0 release blog post. Feel free to leave comments / suggest changes / help me fill in gaps I missed!

NOTE: This is an early draft and there are still a lot of missing pieces / placeholders. Please only review content that exists and point out missing pieces that don't already have placeholders. Anything with a [4724]-style markdown link is a placeholder for content that might need to be included (but also might not be ... these placeholders still need some curation).

@nicopap
Copy link
Contributor

nicopap commented Nov 10, 2022

@MrGVSV May I ask credits in addition to yourself on the implementation of reflection for enums? Note that compared to the whole PR, the correction I provided is not very large, so it's perfectly fine if you refuse.

@MrGVSV
Copy link
Member

MrGVSV commented Nov 10, 2022

@MrGVSV May I ask credits in addition to yourself on the implementation of reflection for enums? Note that compared to the whole PR, the correction I provided is not very large, so it's perfectly fine if you refuse.

Yeah I'm a big believer in giving credit where credit is due. I'd say that since your contributions amounted to more than just a few lines of code, you definitely deserve some amount of credit. And we should also give credit to @Davier for their original PR, which mine was based on.

}
```

No more magic incantations!
Copy link
Member

@MrGVSV MrGVSV Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you want to include this or not, but it could be worth noting that enums do require that all fields implement FromReflect.

This is because, we need to be able to clone data out of a &dyn Reflect and downcast it to the field's type during Reflect::apply. It's not possible to do that without FromReflect1 as Reflect::clone_value may return a Dynamic type for all non-value types (e.g. Struct, TupleStruct, etc.).

Footnotes

  1. Well, it is possible without FromReflect, but all other options were slightly more restrictive imo and could potentially affect the user's desired public API. This included requiring either Default or Clone.

content/news/2022-11-05-bevy-0.9/index.md Outdated Show resolved Hide resolved
@CGMossa
Copy link

CGMossa commented Nov 10, 2022

I suggest to include in the release, that stageless is not part of this release.
You could also amend the fact that an RFC was merged.
While lack of stageless is well known to the discord-crew, the users who come to bevy to try out the stable releases will surely either ask about it on social media, or discover it themselves once they examine the release.

Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also get a top level call to action for subject matter experts for animation and audio? We're shorthanded there.

content/news/2022-11-05-bevy-0.9/index.md Outdated Show resolved Hide resolved
content/news/2022-11-05-bevy-0.9/index.md Outdated Show resolved Hide resolved
content/news/2022-11-05-bevy-0.9/index.md Outdated Show resolved Hide resolved
content/news/2022-11-05-bevy-0.9/index.md Outdated Show resolved Hide resolved
cart and others added 3 commits November 10, 2022 12:43
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
Co-authored-by: Mike <mike.hsu@gmail.com>
Co-authored-by: Mike <mike.hsu@gmail.com>
@cart
Copy link
Member Author

cart commented Nov 10, 2022

@nicopap @MrGVSV I just added both suggested credits to the enum section

@cart
Copy link
Member Author

cart commented Nov 12, 2022

@james7132

Can we also get a top level call to action for subject matter experts for animation and audio? We're shorthanded there.

Done!

@cart cart marked this pull request as ready for review November 12, 2022 08:09

## Derive Resource

<div class="release-feature-authors">authors: @devil-ira</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A large portion of the work was done by Alice. She definitely deserves credit :)


<div class="release-feature-authors">authors: @IceSentry</div>

Some scenarios, [such as shaders](/news/bevy-0-9/#time-shader-globals), need to represent elapsed time values as `f32`, which will suffer from precision issues pretty quickly. To resolve this, [`Time`] has been extended to support "time wrapping":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be interesting to link to The Witness use case as a motivation and best practices.

@Shatur
Copy link

Shatur commented Nov 12, 2022

Looks like you created an extra content/news/2022-11-12-bevy-0.9/bloom_lion (copy).png file in 3bdf3a9

bors bot pushed a commit that referenced this pull request Nov 12, 2022
Fixes breaking changes for 0.9.

Should be merged at the same time as #478.
@cart
Copy link
Member Author

cart commented Nov 12, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 12, 2022
This is an incomplete draft of the 0.9.0 release blog post. Feel free to leave comments / suggest changes / help me fill in gaps I missed!

NOTE: This is an _early_ draft and there are still a lot of missing pieces / placeholders. Please only review content that exists and point out missing pieces that don't already have placeholders. Anything with a `[4724]`-style markdown link is a placeholder for content that _might_  need to be included (but also might not be ... these placeholders still need some curation).
@bors
Copy link

bors bot commented Nov 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title News: Release 0.9.0 [Merged by Bors] - News: Release 0.9.0 Nov 12, 2022
@bors bors bot closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.