-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration guide 0.10 -> 0.11 #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it to line 300 I think 😅 There's a few migration notes that could be improved.
@djeedai I appreciate the review, but this is mostly all auto-generated from the PR description, so I don't really have any answers to most of your comments. I'll try to address what I can but I have very little context about most of those PRs too. |
Co-authored-by: Jerome Humbert <djeedai@gmail.com>
3813317
to
8dd4593
Compare
Yes I appreciate you're working with generated content here and are "only" collecting the work of others. But what's the process then if the migration notes are wrong? Tracking the original author on their PR sounds a lot more work than just fixing here, no? |
Otherwise said, I didn't expect you @IceSentry to be the one to answer all those comments. We probably can ping SMEs for some of them. |
Right, sorry, I mistakenly assumed those questions were for me as the PR author. I already reached to some SMEs for some parts of the migration guide. I'll ping the SMEs later to let them know the guide is ready for them to look over. |
b585222
to
8e70b63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I made a few tweaks and reordered by "usefulness".
Generated the migration guide with the generate-release tool