Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide 0.10 -> 0.11 #655

Merged
merged 24 commits into from
Jul 9, 2023
Merged

Conversation

IceSentry
Copy link
Contributor

Generated the migration guide with the generate-release tool

Copy link
Contributor

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it to line 300 I think 😅 There's a few migration notes that could be improved.

content/learn/migration-guides/0.10-0.11/_index.md Outdated Show resolved Hide resolved
content/learn/migration-guides/0.10-0.11/_index.md Outdated Show resolved Hide resolved
content/learn/migration-guides/0.10-0.11/_index.md Outdated Show resolved Hide resolved
content/learn/migration-guides/0.10-0.11/_index.md Outdated Show resolved Hide resolved
content/learn/migration-guides/0.10-0.11/_index.md Outdated Show resolved Hide resolved
content/learn/migration-guides/0.10-0.11/_index.md Outdated Show resolved Hide resolved
content/learn/migration-guides/0.10-0.11/_index.md Outdated Show resolved Hide resolved
content/learn/migration-guides/0.10-0.11/_index.md Outdated Show resolved Hide resolved
@IceSentry
Copy link
Contributor Author

@djeedai I appreciate the review, but this is mostly all auto-generated from the PR description, so I don't really have any answers to most of your comments. I'll try to address what I can but I have very little context about most of those PRs too.

@djeedai
Copy link
Contributor

djeedai commented Jul 2, 2023

@djeedai I appreciate the review, but this is mostly all auto-generated from the PR description, so I don't really have any answers to most of your comments. I'll try to address what I can but I have very little context about most of those PRs too.

Yes I appreciate you're working with generated content here and are "only" collecting the work of others. But what's the process then if the migration notes are wrong? Tracking the original author on their PR sounds a lot more work than just fixing here, no?

@djeedai
Copy link
Contributor

djeedai commented Jul 2, 2023

Otherwise said, I didn't expect you @IceSentry to be the one to answer all those comments. We probably can ping SMEs for some of them.

@IceSentry
Copy link
Contributor Author

Otherwise said, I didn't expect you @IceSentry to be the one to answer all those comments. We probably can ping SMEs for some of them.

Right, sorry, I mistakenly assumed those questions were for me as the PR author. I already reached to some SMEs for some parts of the migration guide. I'll ping the SMEs later to let them know the guide is ready for them to look over.

@cart cart marked this pull request as ready for review July 9, 2023 07:53
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I made a few tweaks and reordered by "usefulness".

@cart cart enabled auto-merge July 9, 2023 07:54
@cart cart added this pull request to the merge queue Jul 9, 2023
Merged via the queue into bevyengine:main with commit 4d5958f Jul 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants