Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image-compare widget #690

Merged
merged 6 commits into from
Jul 9, 2023
Merged

Conversation

ickk
Copy link
Member

@ickk ickk commented Jul 9, 2023

Use the image-compare widget where it's obvious to do so.

This depends on #689 and cherry-picks #680

The Tonemapping section needs new images that are more suitable for this
and in general it would be good to standardise the placement of and size of titles in the images.
Thanks to @nicopap we can use markup to add titles to the images

@ickk ickk changed the base branch from main to release-0.11.0 July 9, 2023 12:04
@ickk ickk requested a review from nicopap July 9, 2023 12:05
@ickk
Copy link
Member Author

ickk commented Jul 9, 2023

It won't work unless you have #689 as well

@nicopap
Copy link
Contributor

nicopap commented Jul 9, 2023

Yeah. I cherry picked the commit, now it works. Sorry.

Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. A shame we don't have the slider for RCAS off/on and msaa/taa. Those would also benefit from it.

content/news/2023-07-09-bevy-0.11/index.md Outdated Show resolved Hide resolved
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
@ickk
Copy link
Member Author

ickk commented Jul 9, 2023

Hmm. A shame we don't have the slider for RCAS off/on and msaa/taa. Those would also benefit from it.

Hopefully we do a pass on the images before release to standardize them (good to have text/titles in the images themselves I think), and that would be a good opportunity to add RCAS off/on (I need separate images that are full-width).

For msaa/taa I'm not sure whether it's appropriate to compare them. I think no-aa/msaa & no-aa/taa could make more sense?

@nicopap
Copy link
Contributor

nicopap commented Jul 9, 2023

The section titled "Temporal Anti-Aliasing" has an image that is a side-by-side comparison of TAA and MSAA. It would just be an improvement to replace that specific image with a slider comparison.

Whether it's a good comparison or not is orthogonal. But a good reason to compare MSAA and TAA would be a way to point out the various artifacts and improvements each algo have (typically MSAA is still bad with specular highlights, while TAA fixes them).

Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll re-render some of the images and tweak the CSS a bit

@cart cart merged commit ff2fa9d into bevyengine:release-0.11.0 Jul 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants