Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Search on Examples page #742

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Add Search on Examples page #742

merged 2 commits into from
Sep 9, 2023

Conversation

ameknite
Copy link
Contributor

@ameknite ameknite commented Sep 9, 2023

Objective

Since #734 we have a search bar on the assets page, I think it will be good to add it to the example page as well.

IceSentry
IceSentry approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and it seems to work as expected.

Here's a quick video of it in action

bevy_website_example_search.mp4

cart
cart approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazingly straightforward code reuse!

@cart cart added this pull request to the merge queue Sep 9, 2023
Merged via the queue into bevyengine:main with commit 6f20076 Sep 9, 2023
@mockersf mockersf mentioned this pull request Mar 8, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@cart cart cart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ameknite @cart @IceSentry