-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin development chapter to book #848
Merged
alice-i-cecile
merged 10 commits into
bevyengine:main
from
TrialDragon:298_add_plugin_development_chapter
Jan 7, 2024
Merged
Add plugin development chapter to book #848
alice-i-cecile
merged 10 commits into
bevyengine:main
from
TrialDragon:298_add_plugin_development_chapter
Jan 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the order so that it starts with the basic stuff you need when creating your plugin, goes into tips for when developing, then finally the stuff you want when releasing your plugin.
Made it more conversational in tone and obvious that this targets third party plugins.
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
approved these changes
Jan 7, 2024
NthTensor
approved these changes
Jan 7, 2024
NthTensor
reviewed
Jan 7, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
Ready for a maintainer to consider for merging
A-Book
C-Content
labels
Jan 7, 2024
MinerSebas
reviewed
Jan 7, 2024
Comment on lines
+62
to
+64
- Disable Bevy features that you don't use: | ||
- Features are additive => Bevy features enabled in your plugin cannot be disabled by someone using your plugin | ||
- You can find Bevy's features [here](https://github.com/bevyengine/bevy/blob/main/docs/cargo_features.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should explicitly mention the usage ofdefault-features = false
on the bevy dependency, as this could easily be forgotten.
github-merge-queue bot
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Jan 7, 2024
# Objective - Describe the objective or issue this PR addresses. - If you're fixing a specific issue, say "Fixes #X". Removes the old third party plugin guidelines section and related links since it is being moved to the Bevy book in the site per bevyengine/bevy-website#848 and bevyengine/bevy-website#298 ## Solution - Describe the solution used to achieve the objective above. Removes the old links and files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add a chapter on developing third party plugins to the book to make the info on this topic easily findable.
Closes #298