Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13: One-Shot system Improvements #909

Merged

Conversation

Trashtalk217
Copy link
Contributor

For the release notes (#891).

@Nathan-Fenner, I'd love it if you could proofread the text (if you have the time) and let me know if everything is correct.
I have kept it purposefully short, as I don't see it as a particularly big change, just some QOL.

Also, I don't quite know who to credit. I'm currently referring to changes done in

and I've only really given credit to Nathan Fenner so far, as that amounts to the lion's share of the work.

@alice-i-cecile
Copy link
Member

I think Nathan Fenner is the right call for who to credit there: the other PRs are pretty incidental.

Copy link

@Nathan-Fenner Nathan-Fenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few small notes.

From the technical side, I think it's cool that run_system(id) is now just the same as run_system_with_,input(id, ()) - bevy's generic types are quite magically expressive. It is a testament to Bevy's leveraging of Rust's type system just now easy this was to implement.

content/news/2024-02-03-bevy-0.13/index.md Outdated Show resolved Hide resolved
}

let mut world = World::new();
let id = world.register_system(increment_sys);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type of id is slightly different now, it's a SystemId<i32, i32>, (though plain SystemId still works and now means SystemId<(), ()>) which might be worth mentioning- possibly also making the in/out types different in the example to clearly show which is which.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of brevity, I think I'll leave it out of the main post, but I like the idea of adding type annotations and maybe a comment to the code example. I'll do that later.

Copy link
Member

@TrialDragon TrialDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a writer's standpoint this is good in grammar, readability, and being understandable other than what Nathan has already brought up.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review Ready for a maintainer to consider for merging label Feb 5, 2024
@alice-i-cecile alice-i-cecile merged commit 5485b7a into bevyengine:0.13-blog Feb 5, 2024
5 checks passed
@Trashtalk217 Trashtalk217 deleted the one-shot-system-changes branch February 5, 2024 20:33
JMS55 pushed a commit to JMS55/bevy-website-1 that referenced this pull request Feb 13, 2024
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-News C-Content S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants