Skip to content

Commit

Permalink
remove Events from bevy_app, they now live in bevy_ecs
Browse files Browse the repository at this point in the history
  • Loading branch information
pubrrr committed Feb 28, 2022
1 parent 40b3692 commit cf74c0f
Show file tree
Hide file tree
Showing 16 changed files with 28 additions and 20 deletions.
5 changes: 2 additions & 3 deletions crates/bevy_app/src/app.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
use crate::{
CoreStage, Events, Plugin, PluginGroup, PluginGroupBuilder, StartupSchedule, StartupStage,
};
use crate::{CoreStage, Plugin, PluginGroup, PluginGroupBuilder, StartupSchedule, StartupStage};
pub use bevy_derive::AppLabel;
use bevy_ecs::{
event::Events,
prelude::{FromWorld, IntoExclusiveSystem},
schedule::{
IntoSystemDescriptor, RunOnce, Schedule, Stage, StageLabel, State, StateData, SystemSet,
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_app/src/ci_testing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ pub struct CiTestingConfig {
fn ci_testing_exit_after(
mut current_frame: bevy_ecs::prelude::Local<u32>,
ci_testing_config: bevy_ecs::prelude::Res<CiTestingConfig>,
mut app_exit_events: crate::EventWriter<AppExit>,
mut app_exit_events: bevy_ecs::event::EventWriter<AppExit>,
) {
if let Some(exit_after) = ci_testing_config.exit_after {
if *current_frame > exit_after {
Expand Down
1 change: 0 additions & 1 deletion crates/bevy_app/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ mod ci_testing;

pub use app::*;
pub use bevy_derive::DynamicPlugin;
pub use bevy_ecs::event::*;
pub use plugin::*;
pub use plugin_group::*;
pub use schedule_runner::*;
Expand Down
3 changes: 1 addition & 2 deletions crates/bevy_app/src/schedule_runner.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
use crate::{
app::{App, AppExit},
plugin::Plugin,
ManualEventReader,
};
use bevy_ecs::event::Events;
use bevy_ecs::event::{Events, ManualEventReader};
use bevy_utils::{Duration, Instant};

#[cfg(target_arch = "wasm32")]
Expand Down
8 changes: 6 additions & 2 deletions crates/bevy_asset/src/assets.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@ use crate::{
update_asset_storage_system, Asset, AssetLoader, AssetServer, AssetStage, Handle, HandleId,
RefChange,
};
use bevy_app::{App, EventWriter, Events};
use bevy_ecs::{system::ResMut, world::FromWorld};
use bevy_app::App;
use bevy_ecs::{
event::{EventWriter, Events},
system::ResMut,
world::FromWorld,
};
use bevy_utils::HashMap;
use crossbeam_channel::Sender;
use std::fmt::Debug;
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_gilrs/src/gilrs_system.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::converter::{convert_axis, convert_button, convert_gamepad_id};
use bevy_app::EventWriter;
use bevy_ecs::event::EventWriter;
use bevy_ecs::system::{NonSend, NonSendMut};
use bevy_input::{gamepad::GamepadEventRaw, prelude::*};
use gilrs::{EventType, Gilrs};
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_input/src/gamepad.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::{Axis, Input};
use bevy_app::{EventReader, EventWriter};
use bevy_ecs::event::{EventReader, EventWriter};
use bevy_ecs::system::{Res, ResMut};
use bevy_utils::{tracing::info, HashMap, HashSet};

Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_input/src/keyboard.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::{ElementState, Input};
use bevy_app::EventReader;
use bevy_ecs::event::EventReader;
use bevy_ecs::system::ResMut;

/// A key input event from a keyboard device
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_input/src/touch.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use bevy_app::EventReader;
use bevy_ecs::event::EventReader;
use bevy_ecs::system::ResMut;
use bevy_math::Vec2;
use bevy_utils::HashMap;
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_render/src/render_resource/pipeline_cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ use crate::{
renderer::RenderDevice,
RenderWorld,
};
use bevy_app::EventReader;
use bevy_asset::{AssetEvent, Assets, Handle};
use bevy_ecs::event::EventReader;
use bevy_ecs::system::{Res, ResMut};
use bevy_utils::{tracing::error, Entry, HashMap, HashSet};
use std::{hash::Hash, ops::Deref, sync::Arc};
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_scene/src/scene_spawner.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
use crate::{DynamicScene, Scene};
use bevy_app::{Events, ManualEventReader};
use bevy_asset::{AssetEvent, Assets, Handle};
use bevy_ecs::{
entity::{Entity, EntityMap},
event::{Events, ManualEventReader},
reflect::{ReflectComponent, ReflectMapEntities},
system::Command,
world::{Mut, World},
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_ui/src/flex/mod.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
mod convert;

use crate::{CalculatedSize, Node, Style};
use bevy_app::EventReader;
use bevy_ecs::{
entity::Entity,
event::EventReader,
query::{Changed, FilterFetch, With, Without, WorldQuery},
system::{Query, Res, ResMut},
};
Expand Down
1 change: 1 addition & 0 deletions crates/bevy_window/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ keywords = ["bevy"]
[dependencies]
# bevy
bevy_app = { path = "../bevy_app", version = "0.6.0" }
bevy_ecs = { path = "../bevy_ecs", version = "0.6.0" }
bevy_math = { path = "../bevy_math", version = "0.6.0" }
bevy_utils = { path = "../bevy_utils", version = "0.6.0" }
raw-window-handle = "0.4.2"
Expand Down
3 changes: 2 additions & 1 deletion crates/bevy_window/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ pub mod prelude {
};
}

use bevy_app::{prelude::*, Events};
use bevy_app::prelude::*;
use bevy_ecs::event::Events;

pub struct WindowPlugin {
pub add_primary_window: bool,
Expand Down
3 changes: 2 additions & 1 deletion crates/bevy_window/src/system.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use crate::WindowCloseRequested;
use bevy_app::{AppExit, EventReader, EventWriter};
use bevy_app::AppExit;
use bevy_ecs::event::{EventReader, EventWriter};

pub fn exit_on_window_close_system(
mut app_exit_events: EventWriter<AppExit>,
Expand Down
8 changes: 6 additions & 2 deletions crates/bevy_winit/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ use bevy_input::{
pub use winit_config::*;
pub use winit_windows::*;

use bevy_app::{App, AppExit, CoreStage, Events, ManualEventReader, Plugin};
use bevy_ecs::{system::IntoExclusiveSystem, world::World};
use bevy_app::{App, AppExit, CoreStage, Plugin};
use bevy_ecs::{
event::{Events, ManualEventReader},
system::IntoExclusiveSystem,
world::World,
};
use bevy_math::{ivec2, DVec2, Vec2};
use bevy_utils::tracing::{error, trace, warn};
use bevy_window::{
Expand Down

0 comments on commit cf74c0f

Please sign in to comment.