Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Commands' purpose #10805

Closed
Nilirad opened this issue Nov 29, 2023 · 3 comments
Closed

Clarify Commands' purpose #10805

Nilirad opened this issue Nov 29, 2023 · 3 comments
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@Nilirad
Copy link
Contributor

Nilirad commented Nov 29, 2023

Currently, API docs state that Commands are for "impactful changes". However, recent discussions on #10756 made it clear that "structural changes" is a more appropriate and specific term.

The file to modify is found in crates/bevy_ecs/src/system/commands/mod.rs.
@Nilirad Nilirad added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events labels Nov 29, 2023
@xNapha xNapha mentioned this issue Dec 2, 2023
Merged
@xNapha
Copy link
Contributor

xNapha commented Dec 2, 2023

Hello there!
First time contributing to an open-sourced project, so i decided to take this easy issue.
Let me know if I should have added more details or not

@Nilirad
Copy link
Contributor Author

Nilirad commented Dec 2, 2023

For me it is ok as it is. Thank you 👍

github-merge-queue bot pushed a commit that referenced this issue Dec 2, 2023
@xNapha
Clarifying Commands' purpose (#10837)
24c6a7d 
# Objective
As described in [Issue
#10805](#10805) I have changed
"impactful changes" to "structural changes"

## Solution
Updated the text "impactful" to "structural"
@doonv
Copy link
Contributor

doonv commented Jan 6, 2024

This issue should be closed as #10837 was merged.

@Nilirad Nilirad closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nilirad @doonv @xNapha