Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some types in bevy_ui do not reflect the Default trait #11197

Closed
alice-i-cecile opened this issue Jan 3, 2024 · 1 comment · Fixed by #11199
Closed

Some types in bevy_ui do not reflect the Default trait #11197

alice-i-cecile opened this issue Jan 3, 2024 · 1 comment · Fixed by #11199
Labels
A-Reflection Runtime information about types A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member 

          There is probably something missing here and there with the reflect. Noticed that some structs have Default and do not reflect it. Well, didn't touch it for now

Originally posted by @pablo-lua in #11188 (comment)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Jan 3, 2024
@Ato2207
Copy link
Contributor

Ato2207 commented Jan 3, 2024

If it is ok, I'd like to make a PR for this issue and work on it.

This was referenced Jan 3, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this issue Jan 3, 2024
@Ato2207
Made the remaining types from bevy_ui to reflect the Default trait if… (
3f535d5 
#11199)

# Objective

- Fixes #11197

## Solution

- Made the remaining types from bevy_ui that do not reflect the Default
trait to do it if possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made the remaining types from bevy_ui to reflect the Default trait if… Ato2207/bevy
2 participants
@alice-i-cecile @Ato2207