Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translate/rotate/scale helpers to modify mesh vertices #11594

Closed
alice-i-cecile opened this issue Jan 28, 2024 · 0 comments · Fixed by #11675
Closed

Add translate/rotate/scale helpers to modify mesh vertices #11594

alice-i-cecile opened this issue Jan 28, 2024 · 0 comments · Fixed by #11675
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member 

          I'd like to see equivalent helpers for the translate/rotate/scale operations alone (that skip the unneeded ops and take in a type-safe arg), but that can be a second PR.

I don't personally think that transformed_by is worth duplicating the API over, but I won't block over it.

Originally posted by @alice-i-cecile in #11454 (review)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Math Fundamental domain-agnostic mathematical operations labels Jan 28, 2024
@garychia garychia mentioned this issue Feb 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 3, 2024
@garychia
Add helpers for translate, rotate, and scale operations - Mesh (#11675)
1352bf1 
# Objective

- Fixes #11594

## Solution

- Add helpers for translate, rotate, and scale operations.

---

## Changelog

- Added functions `translated_by`, `translate_by`, `rotated_by`,
`rotate_by`, `scaled_by`, and `scale_by`.
tjamaan pushed a commit to tjamaan/bevy that referenced this issue Feb 6, 2024
@garychia @tjamaan
Add helpers for translate, rotate, and scale operations - Mesh (bevye…
87ca79a 
…ngine#11675)

# Objective

- Fixes bevyengine#11594

## Solution

- Add helpers for translate, rotate, and scale operations.

---

## Changelog

- Added functions `translated_by`, `translate_by`, `rotated_by`,
`rotate_by`, `scaled_by`, and `scale_by`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add helpers for translate, rotate, and scale operations - Mesh garychia/bevy
1 participant
@alice-i-cecile