Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant map_flatten lint in workspace #11912

Closed
BD103 opened this issue Feb 17, 2024 · 0 comments · Fixed by #11913
Closed

Redundant map_flatten lint in workspace #11912

BD103 opened this issue Feb 17, 2024 · 0 comments · Fixed by #11913
Labels
C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@BD103
Copy link
Member

BD103 commented Feb 17, 2024

In Cargo.toml, the Clippy lint map_flatten is currently enabled and set to warn.

bevy/Cargo.toml

Line 41 in f81aa64

map_flatten = "warn"

map_flatten is warn by default in stable Rust, so this line is redundant and can be removed.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change labels Feb 17, 2024
@ekropotin ekropotin mentioned this issue Feb 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 17, 2024
@ekropotin
Remove map_flatten from linting rules (#11913)
1076bd4 
# Objective
Remove `map_flatten` rule from Cargo.toml

fixes #11912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove map_flatten from linting rules ekropotin/bevy
2 participants
@alice-i-cecile @BD103