Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CowArc from bevy_utils and use the new atomicow crate instead #14975

Closed
alice-i-cecile opened this issue Aug 29, 2024 · 0 comments · Fixed by #14977
Closed

Remove CowArc from bevy_utils and use the new atomicow crate instead #14975

alice-i-cecile opened this issue Aug 29, 2024 · 0 comments · Fixed by #14977
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@alice-i-cecile
Copy link
Member

As part of #11478, this data structure has been spun out into its own crate.

We should remove bevy_utils implementation and take a dependency on it directly in bevy_assets.
@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! A-Utils Utility functions and types X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Aug 29, 2024
@chrisjuchem chrisjuchem mentioned this issue Aug 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 30, 2024
@chrisjuchem
Replace bevy_utils::CowArc with atomicow (#14977)
e08497d 
# Objective

- Fixes #14975

## Solution

- Replace usages of `bevy_utils::CowArc` with `atomicow::CowArc`
- Remove bevy_utils::CowArc

## Testing

- `bevy_asset` test suite continues to pass.

---

## Migration Guide

`bevy_utils::CowArc` has moved to a new crate called
[atomicow](https://crates.io/crates/atomicow).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace bevy_utils::CowArc with atomicow chrisjuchem/bevy-fork
1 participant
@alice-i-cecile