Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events should use .extend internally #2146

Closed
alice-i-cecile opened this issue May 11, 2021 · 2 comments
Closed

Events should use .extend internally #2146

alice-i-cecile opened this issue May 11, 2021 · 2 comments
Labels
A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

Should improve perf due to better memory allocation vs repeatedly pushing.

See #2145 (comment) by @NathanSWard for more details.

If you want to tackle this, either wait until #2145 is merged or work off that branch, as it changes the code organization of that file.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times labels May 11, 2021
@NathanSWard
Copy link
Contributor

I have a branch for this but will wait until #2145 either gets merged or becomes a little more stable :)

@NathanSWard NathanSWard mentioned this issue May 12, 2021
Closed
@NathanSWard
Copy link
Contributor

This was fixed by #2149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Events::extend with Vec::extend NathanSWard/bevy
2 participants
@alice-i-cecile @NathanSWard