Implement Events::extend with Vec::extend #2149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves impl blocks directly after types, organizes like-types together, presents shared functionality first
Also added handy drain_with_id method
Event buffer's state should not clash with State concept
Direct copy of into_inner for Mut
Consistency with event_consumer and improves simplicity
Fails on line 467, after we try again
Required to ensure Event readers continue functioning correctly
Co-authored-by: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
|
This is based on #2145 so the only change this PR adds is the final commit |
alice-i-cecile
added
C-Code-Quality
|
So, the main question that I have here is should we be benchmarking this, and if so, how? Creating a proper events benchmark would be nice for #2073 as well, if we can design something that works for both. |
NathanSWard
force-pushed
the
nward/events-vec-extend
branch
from
67afc54
to
ffdd605
Compare
Problem: - Events::extend manually called Vec::push for each element of the provided iterator. - This can potentially be an expensive. Solution: - Use Vec::extend over a Vec::push for loop.
NathanSWard
force-pushed
the
nward/events-vec-extend
branch
from
ffdd605
to
2638ec5
Compare
Closed
|
Closing this in favor of a change that's coalescing this and some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
provided iterator.
Solution:
Fixes: #2146
Blocked by: #2145