Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands get ignored when using ParamSet (with minimum example) #4676

Closed
JoJoJet opened this issue May 6, 2022 · 1 comment
Closed

Commands get ignored when using ParamSet (with minimum example) #4676

JoJoJet opened this issue May 6, 2022 · 1 comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior

Comments

@JoJoJet
Copy link
Member

JoJoJet commented May 6, 2022

Bevy version

0.7

Operating system & version

Windows 10

What you did

Wrapped a Commands object in a ParamSet and accessed it with .p0(). Any commands queued this way get ignored.

What you expected to happen

Commands should be queued and then flushed at the end of the stage, just like when using Commands without a ParamSet.

What actually happened

The commands got ignored and were never run.

Additional information

Minimum reproducible example: https://github.com/JoJoJet/param_set_example/blob/main/src/main.rs
@JoJoJet JoJoJet added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels May 6, 2022
@DJMcNab DJMcNab mentioned this issue May 6, 2022
Closed
@DJMcNab DJMcNab added A-ECS Entities, components, systems, and events and removed S-Needs-Triage This issue needs to be labelled labels May 6, 2022
@bors bors bot closed this as completed in ec805e9 May 6, 2022
@JoJoJet
Copy link
Member Author

JoJoJet commented May 6, 2022

I'm continually impressed by how quickly this community responds to issues. Thanks @DJMcNab !

robtfm pushed a commit to robtfm/bevy that referenced this issue May 10, 2022
@DJMcNab @robtfm
Apply buffers in ParamSet (bevyengine#4677)
9078fc3 
# Objective

- Fix bevyengine#4676

## Solution

- Fixes bevyengine#4676
- I have no reason to think this isn't sound, but `ParamSet` is a bit spooky
exjam pushed a commit to exjam/bevy that referenced this issue May 22, 2022
@DJMcNab @exjam
Apply buffers in ParamSet (bevyengine#4677)
a7292c8 
# Objective

- Fix bevyengine#4676

## Solution

- Fixes bevyengine#4676
- I have no reason to think this isn't sound, but `ParamSet` is a bit spooky
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@DJMcNab @ItsDoot
Apply buffers in ParamSet (bevyengine#4677)
dcffedc 
# Objective

- Fix bevyengine#4676

## Solution

- Fixes bevyengine#4676
- I have no reason to think this isn't sound, but `ParamSet` is a bit spooky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Apply buffers in ParamSet DJMcNab/bevy
2 participants
@JoJoJet @DJMcNab