Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

World::get_resource safety comment is incorrect #6307

Closed
alice-i-cecile opened this issue Oct 19, 2022 · 0 comments
Closed

World::get_resource safety comment is incorrect #6307

alice-i-cecile opened this issue Oct 19, 2022 · 0 comments
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change P-Unsound A bug that results in undefined compiler behavior

Comments

@alice-i-cecile
Copy link
Member 

    Not sure how this came to be, but this function does **not**  have unique world access. This safety comment has been incorrect.

Originally posted by @james7132 in #6304 (comment)
@alice-i-cecile alice-i-cecile changed the title World:;get_resource safety comment is incorrect World::get_resource safety comment is incorrect Oct 19, 2022
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change P-Unsound A bug that results in undefined compiler behavior labels Oct 19, 2022
@alice-i-cecile alice-i-cecile mentioned this issue Oct 19, 2022
Closed
@JoJoJet JoJoJet mentioned this issue Nov 26, 2022
Closed
@bors bors bot closed this as completed in 1615834 Nov 28, 2022
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this issue Dec 15, 2022
@JoJoJet @taiyoungjang
Fix an incorrect safety comment in World::get_resource (bevyengine#…
f566a2c 
…6764)

# Objective

* Fix bevyengine#6307

## Solution

* Rewrite the safety comment to reflect the actual invariants being asserted.
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@JoJoJet @alradish
Fix an incorrect safety comment in World::get_resource (bevyengine#…
9d3203d 
…6764)

# Objective

* Fix bevyengine#6307

## Solution

* Rewrite the safety comment to reflect the actual invariants being asserted.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@JoJoJet @ItsDoot
Fix an incorrect safety comment in World::get_resource (bevyengine#…
2f647ae 
…6764)

# Objective

* Fix bevyengine#6307

## Solution

* Rewrite the safety comment to reflect the actual invariants being asserted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change P-Unsound A bug that results in undefined compiler behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Fix an incorrect safety comment in World::get_resource JoJoJet/bevy
1 participant
@alice-i-cecile