Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bloom results in transparency across frame #6634

Closed
DGriffin91 opened this issue Nov 15, 2022 · 0 comments
Closed

Bloom results in transparency across frame #6634

DGriffin91 opened this issue Nov 15, 2022 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior

Comments

@DGriffin91
Copy link
Contributor

Bevy version 0.9

What you did

Combined the transparent_window example with the bloom example. (I'm only using this to quickly test the alpha as my actual use case was much more complex)

What went wrong

There is transparency across the frame, even if the background if opaque.

With default clear color:
image

With ClearColor(Color::NONE):
image
@DGriffin91 DGriffin91 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Nov 15, 2022
@nicopap nicopap added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Nov 15, 2022
@JMS55 JMS55 mentioned this issue Nov 15, 2022
Closed
@james7132 james7132 added this to the 0.9.1 milestone Nov 15, 2022
@JMS55 JMS55 mentioned this issue Nov 18, 2022
Closed
@alice-i-cecile alice-i-cecile removed this from the 0.9.1 milestone Nov 22, 2022
@bors bors bot closed this as completed in 2a7000a Mar 4, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this issue Mar 19, 2023
@JMS55 @StarLederer @Shfty
Revamp Bloom (bevyengine#6677)
beb8f1d 
![image](https://user-images.githubusercontent.com/47158642/220197588-25e11022-02e4-45f3-b2e5-392c4ce7a025.png)

Huge credit to @StarLederer, who did almost all of the work on this. We're just reusing this PR to keep everything in one place.

# Objective

1. Make bloom more physically based.
1. Improve artistic control.
1. Allow to use bloom as screen blur.
1. Fix bevyengine#6634.
1. Address bevyengine#6655 (although the author makes incorrect conclusions).

## Solution

1. Set the default threshold to 0.
2. Lerp between bloom textures when `composite_mode: BloomCompositeMode::EnergyConserving`.
1. Use [a parametric function](https://starlederer.github.io/bloom) to control blend levels for each bloom texture. In the future this can be controlled per-pixel for things like lens dirt.
3. Implement BloomCompositeMode::Additive` for situations where the old school look is desired.

## Changelog

* Bloom now looks different.
* Added `BloomSettings:lf_boost`, `BloomSettings:lf_boost_curvature`, `BloomSettings::high_pass_frequency` and `BloomSettings::composite_mode`.
* `BloomSettings::scale` removed.
* `BloomSettings::knee` renamed to `BloomPrefilterSettings::softness`.
* `BloomSettings::threshold` renamed to `BloomPrefilterSettings::threshold`.
* The bloom example has been renamed to bloom_3d and improved. A bloom_2d example was added.

## Migration Guide

* Refactor mentions of `BloomSettings::knee` and `BloomSettings::threshold` as `BloomSettings::prefilter_settings` where knee is now `softness`.
* If defined without `..default()` add `..default()` to definitions of `BloomSettings` instances or manually define missing fields.
* Adapt to Bloom looking visually different (if needed).

Co-authored-by: Herman Lederer <germans.lederers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bloom alpha handling JMS55/bevy
[Merged by Bors] - Revamp Bloom JMS55/bevy
4 participants
@james7132 @alice-i-cecile @nicopap @DGriffin91