Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadows are messed up #7047

Closed
hymm opened this issue Dec 28, 2022 · 0 comments
Closed

shadows are messed up #7047

hymm opened this issue Dec 28, 2022 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this!

Comments

@hymm
Copy link
Contributor

hymm commented Dec 28, 2022

Bevy version

seems to be this commit ca85f6c. Extract common RenderPhase code into render method (#7013)

Relevant system information

2022-12-28T07:13:54.310551Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon RX 6600", vendor: 4098, device: 29695, device_type: DiscreteGpu, driver: "AMD proprietary driver", driver_info: "22.11.2", backend: Vulkan }
2022-12-28T07:13:54.614800Z  INFO bevy_diagnostic: SystemInfo { os: "Windows 11 Pro", kernel: "22000", cpu: "AMD Ryzen 5 5600X 6-Core Processor", core_count: "6", memory: "15.9 GiB" }

What you did

Ran the 3d_scene example on the before above commit and on it

before:

image

after:

image
@hymm hymm added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Dec 28, 2022
@nicopap nicopap added A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! and removed S-Needs-Triage This issue needs to be labelled labels Dec 28, 2022
@mockersf mockersf mentioned this issue Dec 28, 2022
Closed
@bors bors bot closed this as completed in 61e027e Dec 28, 2022
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@mockersf @alradish
Shadow render phase - pass the correct view entity (bevyengine#7048)
39086a8 
# Objective

- Fixes bevyengine#7047 

## Solution

- Pass the correct view entity
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@mockersf @ItsDoot
Shadow render phase - pass the correct view entity (bevyengine#7048)
3cca041 
# Objective

- Fixes bevyengine#7047 

## Solution

- Pass the correct view entity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Shadow render phase - pass the correct view entity mockersf/bevy
2 participants
@hymm @nicopap