WinitSettings::desktop_app() causes App to keep running after closing window

[akimakinai]

Bevy version

master (de98850a)

What you did

use bevy::{prelude::*, winit::WinitSettings};

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .insert_resource(WinitSettings::desktop_app())
        .run();
}

Ran this code and tried closing window.

What went wrong

App does not exit immediately after window closing. It takes 60 seconds to exit in the end, probably for unfocused_mode.max_wait.

2023-02-11T09:42:27.025503Z  INFO bevy_winit::system: Creating new window "Bevy App" (0v0)
2023-02-11T09:42:30.939804Z  INFO bevy_winit::system: Closing window 0v0
2023-02-11T09:42:30.945907Z  WARN bevy_winit: Window 0v0 is missing `Window` component, skipping event ModifiersChanged((empty))
2023-02-11T09:42:30.946261Z  WARN bevy_winit: Window 0v0 is missing `Window` component, skipping event Focused(false)
2023-02-11T09:42:30.956528Z  WARN bevy_winit: Window 0v0 is missing `Window` component, skipping event Destroyed
2023-02-11T09:43:30.961131Z  INFO bevy_window::system: No windows are open, exiting

The problem disappears when removing WinitSettings::desktop_app() .

[akimakinai]

close_when_requested seems to have moved to PostUpdate. Should it go into Update as before?

bevy/crates/bevy_window/src/lib.rs

Lines 95 to 107 in 3999365

	match self.exit_condition {
	ExitCondition::OnPrimaryClosed => {
	app.add_system_to_stage(CoreStage::PostUpdate, exit_on_primary_closed);
	}
	ExitCondition::OnAllClosed => {
	app.add_system_to_stage(CoreStage::PostUpdate, exit_on_all_closed);
	}
	ExitCondition::DontExit => {}
	}
	if self.close_when_requested {
	app.add_system(close_when_requested);
	}

bevy/crates/bevy_window/src/lib.rs

Lines 94 to 106 in 206c7ce

	match self.exit_condition {
	ExitCondition::OnPrimaryClosed => {
	app.add_system(exit_on_primary_closed.in_set(CoreSet::PostUpdate));
	}
	ExitCondition::OnAllClosed => {
	app.add_system(exit_on_all_closed.in_set(CoreSet::PostUpdate));
	}
	ExitCondition::DontExit => {}
	}
	if self.close_when_requested {
	app.add_system(close_when_requested.in_set(CoreSet::PostUpdate));
	}

[alice-i-cecile]

close_when_requested seems to have moved to PostUpdate. Should it go into Update as before?

Yes please, that seems like a good simple fix to try.