You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While looking through Bevy's source code, I noticed that the ScheduleRunnerPlugin is checking for AppExitEvents twice in the main loop - once immediately before calling App.update() and once immediately after. Meanwhile, the main loop of the WinitPlugin only does this check once in the main loop, a bit after calling App.update().
As the WinitPlugin is only checking for AppExit events once per loop, I believe that means the extra check in ScheduleRunnerPlugin is redundant and unneccessary (Or if it somehow is necessary, it's completely undocumented). The secondary check was added in this commit, if it's any help.
The text was updated successfully, but these errors were encountered:
…#9421)
# Objective
Fixes#9420
## Solution
Remove one of the two `AppExit` event checks in the
`ScheduleRunnerPlugin`'s main loop. Specificially, the check that
happens immediately before calling `App.update()`, to be consistent with
the `WinitPlugin`.
…bevyengine#9421)
# Objective
Fixesbevyengine#9420
## Solution
Remove one of the two `AppExit` event checks in the
`ScheduleRunnerPlugin`'s main loop. Specificially, the check that
happens immediately before calling `App.update()`, to be consistent with
the `WinitPlugin`.
Bevy version
0.11
Description
While looking through Bevy's source code, I noticed that the
ScheduleRunnerPlugin
is checking forAppExitEvents
twice in the main loop - once immediately before callingApp.update()
and once immediately after. Meanwhile, the main loop of theWinitPlugin
only does this check once in the main loop, a bit after callingApp.update()
.As the WinitPlugin is only checking for
AppExit
events once per loop, I believe that means the extra check inScheduleRunnerPlugin
is redundant and unneccessary (Or if it somehow is necessary, it's completely undocumented). The secondary check was added in this commit, if it's any help.The text was updated successfully, but these errors were encountered: