Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register WireframeColor #10486

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Register WireframeColor #10486

merged 1 commit into from
Nov 12, 2023

Conversation

SludgePhD
Copy link
Contributor

@SludgePhD SludgePhD commented Nov 10, 2023 •
edited
Loading

This makes it usable via reflection by adding its data to the TypeRegistry.

@afonsolage
Copy link
Contributor

Even tho this is simple PR, I would advocate for a simple description of why registering WireframeColor is a good idea. The info may be helpful for future or new users who are reading PRs.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 12, 2023
@alice-i-cecile alice-i-cecile added A-Reflection Runtime information about types A-Gizmos Visual editor and debug gizmos C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 12, 2023
Merged via the queue into bevyengine:main with commit 39c8998 Nov 12, 2023
25 checks passed
@SludgePhD SludgePhD deleted the register-WireframeColor branch November 12, 2023 18:16
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@SludgePhD
Register WireframeColor (bevyengine#10486)
dcf20ba 
This makes it usable via reflection by adding its data to the
`TypeRegistry`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsolage afonsolage afonsolage approved these changes

@jakobhellermann jakobhellermann jakobhellermann approved these changes

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SludgePhD @afonsolage @jakobhellermann @alice-i-cecile