Make FakeTask public on singlethreaded context #10517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Task
directly, you can run into errors where you expect aTask
to be returned butFakeTask
is instead. Due toFakeTask
being private the only solution is to ignore the return at all however because it is returned that isn't totally clear. The error is confusing and doesn't provide a solution or help figuring it out.Solution
FakeTask
public and added brief documentation providing a use (none) that helps guide usage (no usage) of FakeTask.