Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IntoSystemConfigs::into_configs public API (visible in docs) #10624

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Make IntoSystemConfigs::into_configs public API (visible in docs) #10624

merged 1 commit into from
Nov 29, 2023

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Nov 18, 2023 •
edited
Loading

IntoSystemConfigs::into_configs function is public, but hidden from documentation. This PR makes it visible.

Fixes #10622.

alice-i-cecile
alice-i-cecile approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change, but we should update the PR description / title to match what's being done here.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 19, 2023
@stepancheg stepancheg changed the title Make IntoSystemConfigs::into_configs public Make IntoSystemConfigs::into_configs public API (visible in docs) Nov 20, 2023
@stepancheg
Copy link
Contributor Author

Done.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 29, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 29, 2023
Merged via the queue into bevyengine:main with commit d04a220 Nov 29, 2023
23 checks passed
james7132 pushed a commit to james7132/bevy that referenced this pull request Dec 1, 2023
@stepancheg @james7132
Make IntoSystemConfigs::into_configs public API (visible in docs) (be…
f33235c 
…vyengine#10624)

`IntoSystemConfigs::into_configs` function is public, but hidden from
documentation. This PR makes it visible.

Fixes bevyengine#10622.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsDoot ItsDoot ItsDoot left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

@maniwani maniwani Awaiting requested review from maniwani

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make IntoSystemConfigs::into_configs public
4 participants
@stepancheg @alice-i-cecile @ItsDoot @JoJoJet