Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Circle Gizmos to Their Own File #10631

Merged
merged 10 commits into from
Nov 20, 2023
Merged

Move Circle Gizmos to Their Own File #10631

merged 10 commits into from
Nov 20, 2023

Commits on Nov 16, 2023

  1. split circle gizmos out into their own file

    @SIGSTACKFAULT
    SIGSTACKFAULT committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d75266e View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. pub use DEFAULT_CIRCLE_SEGMENTS

    @SIGSTACKFAULT
    SIGSTACKFAULT committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    89211d2 View commit details
    Browse the repository at this point in the history

  2. Revert "pub use DEFAULT_CIRCLE_SEGMENTS" 

    turns out DEFAULT_CIRCLE_SEGMENTS wasn't public before and I want to
work on one thing at a time

This reverts commit 89211d2.
    @SIGSTACKFAULT
    SIGSTACKFAULT committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    60395b8 View commit details
    Browse the repository at this point in the history

  3. make circle_inner private 

    not sure why I made it public in the first place
    @SIGSTACKFAULT
    SIGSTACKFAULT committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    84acba4 View commit details
    Browse the repository at this point in the history

  4. make circles and arrows public

    @SIGSTACKFAULT
    SIGSTACKFAULT committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    39dc3a5 View commit details
    Browse the repository at this point in the history

  5. document ArrowBuilder 

    it was already documented but apparently past-me put the doc-comment in
the wrong place, but it happened to be technically private so the linter
didn't complain
    @SIGSTACKFAULT
    SIGSTACKFAULT committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    52311a8 View commit details
    Browse the repository at this point in the history

  6. make DEFAULT_CIRCLE_SEGMENTS pub(crate)

    @SIGSTACKFAULT
    SIGSTACKFAULT committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    d83aea1 View commit details
    Browse the repository at this point in the history

  7. correct link to Gizmos

    @SIGSTACKFAULT
    SIGSTACKFAULT committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    aaae891 View commit details
    Browse the repository at this point in the history

  8. add more documentation to circles and arrows

    @SIGSTACKFAULT
    SIGSTACKFAULT committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    da30530 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Spell "Circles" correctly 

    Co-authored-by: François <mockersf@gmail.com>
    @SIGSTACKFAULT @mockersf
    SIGSTACKFAULT and mockersf authored Nov 19, 2023
    Configuration menu
    Copy the full SHA
    edce806 View commit details
    Browse the repository at this point in the history