Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make impl block for RemovedSystem generic #10651

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

asafigan
Copy link
Contributor

Objective

Make the impl block for RemovedSystem generic so that the methods can be called for systems that have inputs or outputs.

Solution

Simply adding generics to the impl block.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 20, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 21, 2023
@alice-i-cecile
Copy link
Member

Merging as trivial.

Merged via the queue into bevyengine:main with commit a22020b Nov 21, 2023
25 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
# Objective

Make the impl block for RemovedSystem generic so that the methods can be
called for systems that have inputs or outputs.

## Solution

Simply adding generics to the impl block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants