Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove System::{get,set}_last_run #10795

Closed
wants to merge 1 commit into from
Closed

Remove System::{get,set}_last_run #10795

wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

Dead code.

@nicopap nicopap added A-ECS Entities, components, systems, and events M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@mockersf
Copy link
Member

this is in the public API so it can't be dead code, at most it's unused internally

@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Nov 29, 2023
@alice-i-cecile
Copy link
Member

We shouldn't do this: this was specifically added in #5838 for public use.

This was renamed in #7905, so digging up the history was a bit tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stepancheg @mockersf @alice-i-cecile @nicopap