-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for updating the tracing subscriber in LogPlugin #10822
Merged
alice-i-cecile
merged 5 commits into
bevyengine:main
from
cBournhonesque:cb/flexible-log-plugin
Jan 15, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
//! This example illustrates how to add custom log layers in bevy. | ||
|
||
use bevy::{ | ||
log::tracing_subscriber::{layer::SubscriberExt, Layer}, | ||
log::BoxedSubscriber, | ||
prelude::*, | ||
utils::tracing::Subscriber, | ||
}; | ||
|
||
struct CustomLayer; | ||
|
||
impl<S: Subscriber> Layer<S> for CustomLayer { | ||
fn on_event( | ||
&self, | ||
event: &bevy::utils::tracing::Event<'_>, | ||
_ctx: bevy::log::tracing_subscriber::layer::Context<'_, S>, | ||
) { | ||
println!("Got event!"); | ||
println!(" level={:?}", event.metadata().level()); | ||
println!(" target={:?}", event.metadata().target()); | ||
println!(" name={:?}", event.metadata().name()); | ||
} | ||
} | ||
|
||
fn update_subscriber(subscriber: BoxedSubscriber) -> BoxedSubscriber { | ||
Box::new(subscriber.with(CustomLayer)) | ||
} | ||
|
||
fn main() { | ||
App::new() | ||
.add_plugins(DefaultPlugins.set(bevy::log::LogPlugin { | ||
update_subscriber: Some(update_subscriber), | ||
..default() | ||
})) | ||
.add_systems(Update, log_system) | ||
.run(); | ||
} | ||
|
||
fn log_system() { | ||
// here is how you write new logs at each "log level" (in "most import" to | ||
// "least important" order) | ||
error!("something failed"); | ||
warn!("something bad happened that isn't a failure, but thats worth calling out"); | ||
info!("helpful information that is worth printing by default"); | ||
debug!("helpful for debugging"); | ||
trace!("very noisy"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the biggest fan of this naming, but this work. Not a strict blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
extend_tracing_subscriber_fn
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
configure
/configure_callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current name makes sense to me.
configure_subscriber
maybe?