Rename some lifetimes (ResMut etc) for clarity #11021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDoot
approved these changes
Dec 19, 2023
ItsDoot
added
A-ECS
alice-i-cecile
approved these changes
Dec 19, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Thank you for this PR! I lost a lot of time in the past looking up if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
'wfor world lifetime consistently.When implementing system params, useful to look at how other params are implemented.
'wmakes it clear it is world, not state.