Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect: maximally relax TypePath bounds #11037

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

soqb
Copy link
Contributor

@soqb soqb commented Dec 20, 2023

Objective

Solution

  • Changes the bounds of macro-generated TypePath implementations to universally ignore the types of fields, rather than use the same bounds as other implementations. I think this is a more holistic solution than Fix nested generics in Reflect derive #10791 because it totally erases the finicky bounds we currently generate, helping to untangle the reflection trait system.

@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Dec 20, 2023
@ItsDoot ItsDoot added C-Code-Quality A section of code that is hard to understand or change A-Reflection Runtime information about types labels Dec 20, 2023
@ItsDoot ItsDoot added C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Code-Quality A section of code that is hard to understand or change labels Dec 20, 2023
@MrGVSV MrGVSV added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 22, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 24, 2023
Merged via the queue into bevyengine:main with commit 13feac6 Dec 24, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants