Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup bevy winit #11489

Merged
merged 16 commits into from
Jan 28, 2024
Merged

Cleanup bevy winit #11489

merged 16 commits into from
Jan 28, 2024

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 23, 2024

Objective

Get #11257 changes merged.

I rewrote them one by one checking each to ensure correctness. In particular, the window rescale logic changes to accomodate mut app access are double checked. Not all changes have been included as some of bevy_winit has since changed, and i am not confident including them. Namely, the run_app_update_if_should change.

Notes to reviewers

Review commits individually, use the "Hide whitespaces" diff display mode.

Changelog

* `bevy::window::WindowMoved`'s `entity` field has been renamed to `window`

Migration Guide

bevy::window::WindowMoved's entity field has been renamed to window. This is to be more consistent with other windowing events.

Consider changing usage:

-window_moved.entity
+window_moved.window

@Kanabenki Kanabenki added A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jan 23, 2024
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've carefully reviewed this commit-by-commit, and did not see any behavioral changes. I've also tested this on Windows, paying careful attention to the windowing-specific examples.

Copy link
Member

@matiqo15 matiqo15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested on linux + wayland

@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Jan 24, 2024
@dmlary
Copy link
Contributor

dmlary commented Jan 24, 2024

Ran the following examples on macos and confirmed they function as expected with this PR:
multiple_windows
transparent_window
window_fallthrough
window_resizing
window_settings

@rparrett rparrett added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 25, 2024
@mockersf
Copy link
Member

ok for me on macOS, iOS, Android, WebGL2 and WebGPU

@mockersf mockersf added this pull request to the merge queue Jan 28, 2024
Merged via the queue into bevyengine:main with commit eb8de36 Jan 28, 2024
22 checks passed
@nicopap nicopap mentioned this pull request Jan 29, 2024
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
# Objective

Get bevyengine#11257 changes merged.

I rewrote them one by one checking each to ensure correctness. In
particular, the window rescale logic changes to accomodate mut app
access are double checked. Not all changes have been included as some of
bevy_winit has since changed, and i am not confident including them.
Namely, the `run_app_update_if_should` change.

### Notes to reviewers

Review commits individually, use the "Hide whitespaces" diff display
mode.

## Changelog

* `bevy::window::WindowMoved`'s `entity` field has been renamed to
`window`


## Migration Guide

`bevy::window::WindowMoved`'s `entity` field has been renamed to
`window`. This is to be more consistent with other windowing events.

Consider changing usage:

```diff
-window_moved.entity
+window_moved.window
```

---------

Co-authored-by: François <mockersf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants