Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test entity labels, fixed corner cases, changed interface #1152

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Test entity labels, fixed corner cases, changed interface #1152

merged 2 commits into from
Dec 28, 2020

Commits on Dec 26, 2020

  1. Test entity labels, fixed corner cases, changed interface 

    * add tests for entity_labels_system
* fixed filling label_entities map
* fixed corner cases when removing entities, Labels component
* changed EntityLabels::get to return slice or empty slice instead of
  None or Some empty or non-empty slice

Changing the interface of EntityLabels::get is beneficial, since else
you would get different results in case there was an entity before that
with this missing label or not. You would either get None or Some(&[])
and need to handle both, which is actually not necessary.
    @payload
    payload committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    5ef60dc View commit details
    Browse the repository at this point in the history

  2. register type Labels in CorePlugin

    @payload
    payload committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    8c31538 View commit details
    Browse the repository at this point in the history