-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-hardcode positions and colors in 2d_shapes
example
#11867
Conversation
2d_shapes
example
2d_shapes
example2d_shapes
example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, especially the color changes! I just suggested a few places where comments might be appreciated (non-blocking, though). Feel free to reword them however you like.
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a tiny non-blocking suggestion
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Objective
We recently got some neat new 2d shapes and the shapes are no longer centered on the screen.
The hardcoded positions and colors are a pain to deal with when a new shape is added.
Solution
Delete a bunch of code and position shapes evenly. Assign colors evenly too.
Before
After