set pipeline to queued when shader is not yet available #12051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
C-Bug
JMS55
approved these changes
Feb 22, 2024
james7132
approved these changes
Feb 22, 2024
mockersf
added
the
S-Ready-For-Final-Review
Waridley
pushed a commit
to Waridley/bevy
that referenced
this pull request
Feb 23, 2024
…2051) # Objective - Fixes bevyengine#11977 - user defined shaders don't work in wasm - After investigation, it won't work if the shader is not yet available when compiling the pipeline on all platforms, for example if you load many assets ## Solution - Set the pipeline state to queued when it errs waiting for the shader so that it's retried (cherry picked from commit c641882)
Waridley
pushed a commit
to Waridley/bevy
that referenced
this pull request
Feb 24, 2024
…2051) # Objective - Fixes bevyengine#11977 - user defined shaders don't work in wasm - After investigation, it won't work if the shader is not yet available when compiling the pipeline on all platforms, for example if you load many assets ## Solution - Set the pipeline state to queued when it errs waiting for the shader so that it's retried (cherry picked from commit c641882)
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…2051) # Objective - Fixes bevyengine#11977 - user defined shaders don't work in wasm - After investigation, it won't work if the shader is not yet available when compiling the pipeline on all platforms, for example if you load many assets ## Solution - Set the pipeline state to queued when it errs waiting for the shader so that it's retried
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…2051) # Objective - Fixes bevyengine#11977 - user defined shaders don't work in wasm - After investigation, it won't work if the shader is not yet available when compiling the pipeline on all platforms, for example if you load many assets ## Solution - Set the pipeline state to queued when it errs waiting for the shader so that it's retried
mockersf
added a commit
that referenced
this pull request
Feb 27, 2024
# Objective - Fixes #11977 - user defined shaders don't work in wasm - After investigation, it won't work if the shader is not yet available when compiling the pipeline on all platforms, for example if you load many assets ## Solution - Set the pipeline state to queued when it errs waiting for the shader so that it's retried
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution