Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort alpha masked pipelines by pipeline & mesh instead of by distance #12117

Merged
merged 1 commit into from
Feb 26, 2024
Merged

sort alpha masked pipelines by pipeline & mesh instead of by distance #12117

merged 1 commit into from
Feb 26, 2024

Conversation

Elabajaba
Copy link
Contributor

@Elabajaba Elabajaba commented Feb 26, 2024 •
edited
Loading

Objective

Solution

  • Change the sorting for alpha mask phases to sort by pipeline+mesh instead of distance, for much better batching for alpha masked materials.

I also fixed some docs that I missed in the previous PR.

Changelog

  • Alpha masked materials are now sorted by pipeline and mesh.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times labels Feb 26, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Feb 26, 2024
@superdump superdump added this pull request to the merge queue Feb 26, 2024
Merged via the queue into bevyengine:main with commit 78b6fa1 Feb 26, 2024
27 checks passed
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@Elabajaba @msvbg
sort alpha masked pipelines by pipeline & mesh instead of by distance (…
6b993b5 
…bevyengine#12117)

# Objective

- followup to bevyengine#11671
- I forgot to change the alpha masked phases.

## Solution

- Change the sorting for alpha mask phases to sort by pipeline+mesh
instead of distance, for much better batching for alpha masked
materials.

I also fixed some docs that I missed in the previous PR.

---

## Changelog
- Alpha masked materials are now sorted by pipeline and mesh.
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@Elabajaba @msvbg
sort alpha masked pipelines by pipeline & mesh instead of by distance (…
7ae99e5 
…bevyengine#12117)

# Objective

- followup to bevyengine#11671
- I forgot to change the alpha masked phases.

## Solution

- Change the sorting for alpha mask phases to sort by pipeline+mesh
instead of distance, for much better batching for alpha masked
materials.

I also fixed some docs that I missed in the previous PR.

---

## Changelog
- Alpha masked materials are now sorted by pipeline and mesh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@Elabajaba @superdump @alice-i-cecile