Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example lightmaps after color migration #12265

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 2, 2024

Objective

Screenshot 2024-03-02 at 23 04 36

Solution

Screenshot 2024-03-02 at 23 05 09

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Mar 2, 2024
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is an interesting case where the gamma correction of Srgba is useful. Good catch.

We should impl Div and the reciprocal Mul in this PR too however.

Copy link
Contributor

@pablo-lua pablo-lua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Mul and Div implementation, and the example is better now.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 3, 2024
Merged via the queue into bevyengine:main with commit faa2ce4 Mar 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants