Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_reflect: Function reflection #13152

Merged
merged 31 commits into from
Jul 1, 2024
Merged

bevy_reflect: Function reflection #13152

merged 31 commits into from
Jul 1, 2024

Commits on May 22, 2024

  1. Add support for dynamic functions

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    784a329 View commit details
    Browse the repository at this point in the history

  2. Add support for reference return types

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4e47c86 View commit details
    Browse the repository at this point in the history

  3. Simplify ArgInfo

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2d8804d View commit details
    Browse the repository at this point in the history

  4. Add ReturnInfo

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    42f51e9 View commit details
    Browse the repository at this point in the history

  5. Simplify Debug output for Function

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    277c3cb View commit details
    Browse the repository at this point in the history

  6. Update FunctionInfo::new signature 

    Removed the `args` parameter, opting fully into the `with_***` pattern
    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d274242 View commit details
    Browse the repository at this point in the history

  7. Add ArgList::new function

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6395ff5 View commit details
    Browse the repository at this point in the history

  8. Add documentation

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4dd061c View commit details
    Browse the repository at this point in the history

  9. Rename module 

    into -> into_function
    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    83c4090 View commit details
    Browse the repository at this point in the history

  10. Move local macros to derive macro

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    73f07b9 View commit details
    Browse the repository at this point in the history

  11. Derive Debug on Arg and ArgList

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4c62a83 View commit details
    Browse the repository at this point in the history

  12. Add lifetime to Function

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d6ab4c0 View commit details
    Browse the repository at this point in the history

  13. Allow &mut receiver to return & data

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    33eefd6 View commit details
    Browse the repository at this point in the history

  14. Add function_reflection example

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    010121e View commit details
    Browse the repository at this point in the history

  15. Fix formatting and lints

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f0b575d View commit details
    Browse the repository at this point in the history

  16. Apply suggestions from code review 

    Co-authored-by: Periwink <charlesbour@gmail.com>
    @MrGVSV @cBournhonesque
    MrGVSV and cBournhonesque committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6952bce View commit details
    Browse the repository at this point in the history

  17. Update docs

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e51ac2c View commit details
    Browse the repository at this point in the history

  18. Add some basic compile fail tests

    @MrGVSV
    MrGVSV committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a70dd8a View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Expose function info

    @MrGVSV
    MrGVSV committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    210564d View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Add clarifying doc comment

    @MrGVSV
    MrGVSV committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    aa000ff View commit details
    Browse the repository at this point in the history

  2. Update derives on function info types 

    Added `Clone` to `FunctionInfo` and `ReturnInfo`,
and removed `PartialEq` + `Eq` from `ArgInfo`.

Removed the derives on `ArgInfo` for future-proofing.
    @MrGVSV
    MrGVSV committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c6f7501 View commit details
    Browse the repository at this point in the history

  3. Rename Function -> DynamicFunction 

    This keeps the name `Function` open for possible future use as
a reflection trait
    @MrGVSV
    MrGVSV committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9d01602 View commit details
    Browse the repository at this point in the history

  4. Rename FuncError -> FunctionError

    @MrGVSV
    MrGVSV committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e997efa View commit details
    Browse the repository at this point in the history

  5. Add manual construction example to DynamicFunction

    @MrGVSV
    MrGVSV committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8654233 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Improve documentation

    @MrGVSV
    MrGVSV committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    184af80 View commit details
    Browse the repository at this point in the history

  2. Improve macro documentation

    @MrGVSV
    MrGVSV committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    4088843 View commit details
    Browse the repository at this point in the history

  3. Make FunctionError variants sound more error-y

    @MrGVSV
    MrGVSV committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    b8ed0a8 View commit details
    Browse the repository at this point in the history

  4. Remove incorrect section from example 

    Closures no longer need to be `'static` as we now track the
lifetime of the wrapped function
    @MrGVSV
    MrGVSV committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ba72789 View commit details
    Browse the repository at this point in the history

  5. Use Marker instead of T for IntoFunction 

    This takes after similar concepts in bevy_ecs
    @MrGVSV
    MrGVSV committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    1b32c3e View commit details
    Browse the repository at this point in the history

  6. Infer function name using std::any::type_name

    @MrGVSV
    MrGVSV committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    c95210c View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Implement IntoFunction for DynamicFunction

    @MrGVSV
    MrGVSV committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    91f249f View commit details
    Browse the repository at this point in the history