12660 progress and small optimization #13244
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Co-authored-by: Pascal Hertleif <killercup@gmail.com>
Co-authored-by: Pascal Hertleif <killercup@gmail.com>
Co-authored-by: Pascal Hertleif <killercup@gmail.com>
pablo-lua
added
C-Usability
matiqo15
added
the
C-Code-Quality
Co-authored-by: François Mockers <francois.mockers@vleue.com>
There was a problem hiding this comment.
I think messages in expect should be more helpful than some of those to be useful. They should provide some more context than reading the code does:
- as the API user, does this helps me with debugging without reading the code?
- does it provides me info on which inputs I gave that created the panic?
- does it informs me on why they are invalid?
Replacing unwrap by expect without providing this kind of details is not helpful, and will require people who want to improve it later to understand more context, it includes strings in the binary that takes up a small place, and provides a false sense of "we don't use unwrap"
mockersf
removed
the
S-Ready-For-Final-Review
| let search_result = self.keyframe_timestamps.binary_search_by(|probe| { | ||
| probe | ||
| .partial_cmp(&seek_time) | ||
| .expect("provided floats can't be compared") |
There was a problem hiding this comment.
what are those floats? why are they compared? which is an input provided by the user when calling this function?
janhohenheim
added
the
S-Waiting-on-Author
Objective
small effort towards #12660 along with a small optimization found in the process
first commit