Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Skybox Motion Vectors #13617

Merged
merged 9 commits into from
Jun 2, 2024
Merged

Add Skybox Motion Vectors #13617

merged 9 commits into from
Jun 2, 2024

Conversation

aevyrie
Copy link
Member

@aevyrie aevyrie commented Jun 1, 2024 •
edited
Loading

Objective

  • Add motion vector support to the skybox
  • This fixes the last remaining "gap" to complete the motion blur feature

Solution

  • Add a pipeline for the skybox to write motion vectors to the prepass

Testing

  • Used examples to test motion vectors using motion blur
Screen.Recording.2024-06-01.at.1.59.19.AM.mp4

@aevyrie aevyrie added the A-Rendering Drawing game state to the screen label Jun 1, 2024
@aevyrie aevyrie added this to the 0.14 milestone Jun 1, 2024
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible X-Uncontroversial This work is generally agreed upon D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 1, 2024
pcwalton
pcwalton approved these changes Jun 1, 2024
View reviewed changes
crates/bevy_core_pipeline/src/prepass/mod.rs Show resolved Hide resolved
crates/bevy_core_pipeline/src/skybox/prepass.rs Outdated Show resolved Hide resolved
crates/bevy_core_pipeline/src/skybox/skybox_prepass.wgsl Outdated Show resolved Hide resolved
IceSentry
IceSentry approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a skybox to the motion_blur example would be nice

@IceSentry
Copy link
Contributor

IceSentry commented Jun 2, 2024 •
edited
Loading

Uh, I meant that as a comment, not an approve 😅

@IceSentry IceSentry self-requested a review June 2, 2024 03:50
IceSentry
IceSentry approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming comments are adressed

@IceSentry IceSentry added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 2, 2024
@aevyrie
Copy link
Member Author

aevyrie commented Jun 2, 2024

Adding a skybox to the motion_blur example would be nice

I agree. I tried this out, but frankly it looks awful with the skyboxes we have available in tree. It would be nice if we had a simpler sky-and-clouds skybox and envmap.

@aevyrie aevyrie added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jun 2, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 2, 2024
@alice-i-cecile alice-i-cecile mentioned this pull request Jun 2, 2024
Open
Merged via the queue into bevyengine:main with commit b45786d Jun 2, 2024
28 checks passed
@aevyrie aevyrie deleted the skybox-prepass branch June 3, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@pcwalton pcwalton pcwalton approved these changes

@torsteingrindvik torsteingrindvik torsteingrindvik approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
5 participants
@aevyrie @IceSentry @pcwalton @torsteingrindvik @alice-i-cecile