Update ndk-glue requirement from 0.2 to 0.3

[dependabot]

Updates the requirements on ndk-glue to permit the latest version.

Commits

• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[cart]

/rebase

[bjorn3]

It failed: https://github.com/bevyengine/bevy/actions/runs/528810573

Input required and not supplied: token

[cart]

Haha thanks! Investigating now.

[cart]

Forgot to update one of the secret names

[cart]

/rebase

[cart]

@bjorn3 looks like the latency is ~30 seconds (and ~3 seconds for comments that dont match). Off the top of your head do you know what bors-ng latency is like?

[bjorn3]

I don't know exactly. I tried looking at the time between an r+ on rust-analyzer and the stated author time of the merge commit, but due to clock skew the merge commit said that it was created before the r+. I do expect it to be much faster though as it doesn't have to start a container to run in and I think it uses the github api to merge the PR into a new branch rather than checking it out locally.

[cart]

Makes sense. I'm still on the fence about this approach. I like it because of the minimalism, the "github nativeness", and most importantly the cleanness of the commit history.

I dislike it because it isn't as safe as bors, you must do one pr at a time, it's a "two step process", and it might be slower than bors (although 30 seconds isn't untenable).

[cart]

Looks like we can't merge this until cpal updates to ndk-glue 0.3.0. I'm getting a black screen and crash from ndk-glue 0.2.1:

02-01 13:09:54.866   983  3115 I ActivityManager: START u0 {act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=rust.example.button/android.app.NativeActivity bnds=[234,533][438,840]} from uid 10040
02-01 13:09:54.919   983  1077 I ActivityManager: Start proc 12885:rust.example.button/u0a163 for activity rust.example.button/android.app.NativeActivity
02-01 13:09:54.925 12885 12885 I .example.butto: Late-enabling -Xcheck:jni
02-01 13:09:55.035 12885 12885 W System  : ClassLoader referenced unknown path:
02-01 13:09:55.110 12885 12885 D OpenGLRenderer: Skia GL Pipeline
02-01 13:09:55.219 12885 12903 I RustStdoutStderr: thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', /home/carter/.cargo/registry/src/github.com-1ecc6299db9ec823/ndk-glue-0.2.1/src/lib.rs:42:39
02-01 13:09:55.219 12885 12903 I RustStdoutStderr: note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
02-01 13:09:55.227 17995 17995 I GoogleInputMethodService: GoogleInputMethodService.onFinishInput():3341
02-01 13:09:55.227 17995 17995 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1906
02-01 13:09:55.238   560   596 E ANDR-PERF-OPTSHANDLER: perf_lock_rel: updated /sys/class/scsi_host/host0/../../../clkscale_enable with 1
02-01 13:09:55.238   560   596 E ANDR-PERF-OPTSHANDLER:  return value 2
02-01 13:09:55.246   983  1074 I ActivityManager: Displayed rust.example.button/android.app.NativeActivity: +369ms
02-01 13:09:55.404   575   627 W SurfaceFlinger: Attempting to set client state on removed layer: Splash Screen rust.example.button#0
02-01 13:09:55.404   575   627 W SurfaceFlinger: Attempting to destroy on removed layer: Splash Screen rust.example.button#0
02-01 13:09:55.404   575   628 W SurfaceFlinger: Attempting to set client state on removed layer: Surface(name=febe857 Splash Screen rust.example.button)/@0x7edbfe5 - animation-leash#0
02-01 13:09:55.404   575   628 W SurfaceFlinger: Attempting to destroy on removed layer: Surface(name=febe857 Splash Screen rust.example.button)/@0x7edbfe5 - animation-leash#0
02-01 13:09:55.522   575   627 W SurfaceFlinger: Attempting to set client state on removed layer: Surface(name=AppWindowToken{c62a281 token=Token{7c72e68 ActivityRecord{ece6d8b u0 rust.example.button/android.app.NativeActivity t20823}}})/@0x2869f44 - animation-leash#0
02-01 13:09:55.522   575   627 W SurfaceFlinger: Attempting to set client state on removed layer: Surface(name=AppWindowToken{5f7a39b token=Token{f5d7baa ActivityRecord{6b87e95 u0 com.android.launcher3/.lineage.LineageLauncher t20407}}})/@0xa711a3a - animation-leash#0
02-01 13:09:55.522   575   627 W SurfaceFlinger: Attempting to destroy on removed layer: Surface(name=AppWindowToken{c62a281 token=Token{7c72e68 ActivityRecord{ece6d8b u0 rust.example.button/android.app.NativeActivity t20823}}})/@0x2869f44 - animation-leash#0
02-01 13:09:55.522   575   627 W SurfaceFlinger: Attempting to destroy on removed layer: Surface(name=AppWindowToken{5f7a39b token=Token{f5d7baa ActivityRecord{6b87e95 u0 com.android.launcher3/.lineage.LineageLauncher t20407}}})/@0xa711a3a - animation-leash#0

[mnmaita]

Looks like we can't merge this until cpal updates to ndk-glue 0.3.0. I'm getting a black screen and crash from ndk-glue 0.2.1:

Might be relevant: RustAudio/cpal@eaf4018

[MinerSebas]

cpal released the update with the ndk-glue version bump

[alice-i-cecile]

Caused crash due to an upstream dependency. That dependency has released a new Version and PR should be retested.
-> Suggestion: Add to Milestone and/or ready for cart Label

@MinerSebas Looks like this is ready to test, but I don't think it's critical enough to warrant the 0.5 milestone (although it would be nice to get in).

[mockersf]

If someone can test on an android and confirm it's ok, it would be nice to do the update for 0.5 as we now have both versions in our dependencies which may make it crash on android

[inodentry]

Cannot compile due to rustc error in oboe dependency:

   Compiling oboe v0.4.0
error: attribute must be applied to a `static` variable
   --> /home/jamadazi/.cargo/registry/src/github.com-1ecc6299db9ec823/oboe-0.4.0/src/audio_stream.rs:625:5
    |
625 |     #[used]
    |     ^^^^^^^

error: aborting due to previous error

error: could not compile `oboe`

[inodentry]

Patching to use oboe from git gets it to compile, but the example does not work (even with MSAA disabled). I get a black screen and eventual crash.

I'll make an issue on the oboe repo to let them know about the error and ask them to make a patch release.

EDIT: katyo/oboe-rs#27

[dependabot]

A newer version of ndk-glue exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

[mockersf]

done in #2684

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.